Conversation
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ryanbas21
force-pushed
the
ssr-jc
branch
3 times, most recently
from
3088dc6 to
1e39459
Compare
|
View your CI Pipeline Execution ↗ for commit c01705c
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗. ☁️ Nx Cloud last updated this comment at |
ryanbas21
force-pushed
the
ssr-jc
branch
2 times, most recently
from
754ed3c to
32a9242
Compare
ryanbas21
force-pushed
the
ssr-jc
branch
4 times, most recently
from
2398cad to
c01705c
Compare
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nx Cloud is proposing a fix for your failed CI:
These changes fix the build and typecheck failures introduced by the incomplete migration of createAuthorizeUrl to return AuthorizeUrlResult instead of string. We restored the RTK error-handling helpers (isFetchBaseQueryError, toDispatchError, toAuthorizationError) that were removed from authorize.request.utils.ts but were still imported by authorize.request.micros.ts, and updated all callsites and tests to extract .url from the new return shape.
Warning
- ❌ We could not verify this fix.
- The suggested diff is too large to display here, but you can view it on Nx Cloud ↗
Or Apply changes locally with:
npx nx-cloud apply-locally vpxo-fbnU
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
Make journey-client and oidc-client importable and usable in Node.js/SSR
environments by eliminating eager browser global references and decoupling
PKCE generation from sessionStorage.
Storage: Replace eager sessionStorage/localStorage references with lazy
globalThis access via getBrowserStorage(). Add configurable storage option
to JourneyClientConfig so SSR callers can provide a custom noop adapter.
PKCE: Decouple generation from storage — createAuthorizeUrl now returns
{ url, verifier, state } instead of writing to sessionStorage. Callers
persist PKCE values however they choose (cookies, server session, etc.).
Token exchange accepts optional pkceValues parameter to skip sessionStorage.
Guard redirect() with typeof window check for server environments.
Export createJourneyObject for client-side step reconstitution.
SvelteKit PoC in e2e/svelte-app demonstrates the full flow:
server-side journey start, client-side credential submission,
server-side PKCE authorize URL generation with cookie-based verifier
persistence, and server-side token exchange against the AM mock API.
1 participant
Summary
This is a complete proof of concept — not finished work. It demonstrates the changes needed to make
journey-clientandoidc-clientwork in server-side rendering environments (SvelteKit, Next.js, etc.).Problem
@forgerock/storageeagerly referencessessionStorage/localStorageglobals, crashing on import in Node.jscreateAuthorizeUrlcouples PKCE generation withsessionStorage, preventing server-side authorize URL creationwindow.location.assign()inredirect()has no server guardChanges
Storage (
@forgerock/storage)globalThisaccess viagetBrowserStorage()type: 'custom'with a no-op adapter — no new types neededJourney Client (
@forgerock/journey-client)storageconfig toJourneyClientConfig(defaults to sessionStorage)redirect()withtypeof windowcheckcreateJourneyObjectfor client-side step reconstitution after SSROIDC / PKCE (
@forgerock/sdk-oidc,@forgerock/oidc-client)createAuthorizeUrlnow returns{ url, verifier, state }instead of writing to sessionStoragetoken.exchange()accepts optionalpkceValuesparameter to skip sessionStorage lookupSvelteKit PoC (
e2e/svelte-app)start()→ SSR-rendered login formnext()Test plan
nx run storage:test— 21 tests passnx run journey-client:test— 193 tests passnx run sdk-oidc:test— 26 tests passnx run oidc-client:test— 21 tests passnx run davinci-client:test— 226 tests passam-mock-api:serve+vite devine2e/svelte-app, verify SSR rendering and token exchange